Skip to content

Conversation

@theroggy
Copy link
Member

@theroggy theroggy commented Jul 5, 2025

This PR:

TODO:

  • remove rttopo as it is GPL

resolves #378

@dg0yt
Copy link

dg0yt commented Jul 5, 2025

Would it help to include libspatialite without freexl?

@theroggy
Copy link
Member Author

theroggy commented Jul 5, 2025

Would it help to include libspatialite without freexl?

Yes, good idea: freexl is not needed for our use!

I'll give it a try.

@dg0yt
Copy link

dg0yt commented Jul 5, 2025

A little bit different. Add libspatialite as a top-level dependency, with default-features: false.

@dg0yt
Copy link

dg0yt commented Jul 6, 2025

vcpkg linux logs are still reported to be in /opt/vcpkg/buildtrees - this is not what is uploaded in the next step.

@theroggy
Copy link
Member Author

theroggy commented Jul 7, 2025

vcpkg linux logs are still reported to be in /opt/vcpkg/buildtrees - this is not what is uploaded in the next step.

Thanks for having a look! I'm not a specialist at all in this, so much appreciated!

I only made the change in one of the 3 linux containers/builds (manylinux_2_28_x86_64-vcpkg-gdal), so sorry for the confusion. I now changed it in all three...

But, the log files are not found anyway...

I wondered if it has something to do with paths in the container versus local paths, so I tried copying the files first to a local path,, but I don't seem to get that working either :-(...

@theroggy theroggy changed the title BUILD: quick check if LibSpatialite can be included now BUILD: add LibSpatialite to wheels Sep 25, 2025
@theroggy theroggy changed the title BUILD: add LibSpatialite to wheels BLD/REL: add LibSpatialite to wheels Sep 26, 2025
@theroggy theroggy marked this pull request as ready for review September 26, 2025 09:24
@theroggy theroggy added this to the 0.12.0 milestone Sep 26, 2025
@theroggy theroggy changed the title BLD/REL: add LibSpatialite to wheels BLD/REL: add libspatialite to the wheels Sep 27, 2025
@jorisvandenbossche
Copy link
Member

@theroggy this seems to "just work" now?

@theroggy
Copy link
Member Author

theroggy commented Oct 14, 2025

@theroggy this seems to "just work" now?

Yes, indeed... something must have been fixed upstream...

@jorisvandenbossche
Copy link
Member

As discussed in the community meeting, let's leave out rttopo for now given that this is GPL and it is not entirely clear what the impact would be for the wheels

@jorisvandenbossche
Copy link
Member

The manylinux2014 build is now failing ... Not 100% it is related to this PR (although it is minizip that is failing, and I don't see that included in the build on main), but if so, could also just leave spatialite out of those wheels, and only add it to the main vcpkg.json

@dg0yt
Copy link

dg0yt commented Oct 31, 2025

In vpckg, zlib and minizip are a 1.3.1. (Same source.)
But this repo has a zlib overlay port at 1.2.5.2.

@dg0yt
Copy link

dg0yt commented Oct 31, 2025

And yes. libspatialite needs freexl needs minizip.

@theroggy
Copy link
Member Author

@dg0yt thanks for the input!

I excluded freexl from libspatialite on manylinux2014, as freexl isn't that important, and now it builds fine on manylinux2014 as well.

@jorisvandenbossche
Copy link
Member

Should we exclude freexl generally? If we don't think it is that useful (it's for spreadsheet support? but libspatialite is for sqlite files?), I would rather not add it at all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BLD/RLS: to include spatialite in wheels or not to?

3 participants